Closed
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062380
Total [baseline] (8.731 s) : 0, 8731168
Agent [candidate] (1.062 s) : 0, 1062460
Total [candidate] (8.724 s) : 0, 8724267
section iast
Agent [baseline] (1.236 s) : 0, 1236213
Total [baseline] (9.389 s) : 0, 9389446
Agent [candidate] (1.236 s) : 0, 1236263
Total [candidate] (9.4 s) : 0, 9400267
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (627.121 ms) : 0, 627121
BytebuddyAgent [candidate] (626.278 ms) : 0, 626278
AgentMeter [baseline] (29.037 ms) : 0, 29037
AgentMeter [candidate] (29.058 ms) : 0, 29058
GlobalTracer [baseline] (256.67 ms) : 0, 256670
GlobalTracer [candidate] (257.16 ms) : 0, 257160
AppSec [baseline] (33.083 ms) : 0, 33083
AppSec [candidate] (32.823 ms) : 0, 32823
Debugger [baseline] (65.986 ms) : 0, 65986
Debugger [candidate] (65.012 ms) : 0, 65012
Remote Config [baseline] (614.612 µs) : 0, 615
Remote Config [candidate] (604.955 µs) : 0, 605
Telemetry [baseline] (9.02 ms) : 0, 9020
Telemetry [candidate] (10.556 ms) : 0, 10556
Flare Poller [baseline] (3.795 ms) : 0, 3795
Flare Poller [candidate] (3.745 ms) : 0, 3745
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (800.2 ms) : 0, 800200
BytebuddyAgent [candidate] (799.784 ms) : 0, 799784
AgentMeter [baseline] (11.517 ms) : 0, 11517
AgentMeter [candidate] (11.519 ms) : 0, 11519
GlobalTracer [baseline] (248.569 ms) : 0, 248569
GlobalTracer [candidate] (248.444 ms) : 0, 248444
AppSec [baseline] (32.197 ms) : 0, 32197
AppSec [candidate] (31.528 ms) : 0, 31528
Debugger [baseline] (66.71 ms) : 0, 66710
Debugger [candidate] (68.057 ms) : 0, 68057
Remote Config [baseline] (535.054 µs) : 0, 535
Remote Config [candidate] (535.143 µs) : 0, 535
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.513 ms) : 0, 8513
Flare Poller [baseline] (3.514 ms) : 0, 3514
Flare Poller [candidate] (3.412 ms) : 0, 3412
IAST [baseline] (27.047 ms) : 0, 27047
IAST [candidate] (27.174 ms) : 0, 27174
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064648
Total [baseline] (10.738 s) : 0, 10738469
Agent [candidate] (1.073 s) : 0, 1073042
Total [candidate] (10.913 s) : 0, 10912600
section appsec
Agent [baseline] (1.249 s) : 0, 1249255
Total [baseline] (11.049 s) : 0, 11049478
Agent [candidate] (1.242 s) : 0, 1242179
Total [candidate] (11.078 s) : 0, 11077898
section iast
Agent [baseline] (1.243 s) : 0, 1242990
Total [baseline] (11.199 s) : 0, 11199298
Agent [candidate] (1.238 s) : 0, 1237755
Total [candidate] (11.224 s) : 0, 11224259
section profiling
Agent [baseline] (1.187 s) : 0, 1187358
Total [baseline] (10.909 s) : 0, 10909482
Agent [candidate] (1.191 s) : 0, 1190783
Total [candidate] (10.896 s) : 0, 10895714
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (626.957 ms) : 0, 626957
BytebuddyAgent [candidate] (632.997 ms) : 0, 632997
AgentMeter [baseline] (29.034 ms) : 0, 29034
AgentMeter [candidate] (29.27 ms) : 0, 29270
GlobalTracer [baseline] (257.446 ms) : 0, 257446
GlobalTracer [candidate] (259.302 ms) : 0, 259302
AppSec [baseline] (32.757 ms) : 0, 32757
AppSec [candidate] (33.349 ms) : 0, 33349
Debugger [baseline] (65.331 ms) : 0, 65331
Debugger [candidate] (63.327 ms) : 0, 63327
Remote Config [baseline] (615.281 µs) : 0, 615
Remote Config [candidate] (620.53 µs) : 0, 621
Telemetry [baseline] (9.88 ms) : 0, 9880
Telemetry [candidate] (11.52 ms) : 0, 11520
Flare Poller [baseline] (5.403 ms) : 0, 5403
Flare Poller [candidate] (5.353 ms) : 0, 5353
section appsec
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (662.519 ms) : 0, 662519
BytebuddyAgent [candidate] (658.874 ms) : 0, 658874
AgentMeter [baseline] (12.065 ms) : 0, 12065
AgentMeter [candidate] (12.055 ms) : 0, 12055
GlobalTracer [baseline] (260.692 ms) : 0, 260692
GlobalTracer [candidate] (259.738 ms) : 0, 259738
AppSec [baseline] (169.157 ms) : 0, 169157
AppSec [candidate] (168.801 ms) : 0, 168801
Debugger [baseline] (67.64 ms) : 0, 67640
Debugger [candidate] (66.416 ms) : 0, 66416
Remote Config [baseline] (650.754 µs) : 0, 651
Remote Config [candidate] (643.303 µs) : 0, 643
Telemetry [baseline] (9.64 ms) : 0, 9640
Telemetry [candidate] (9.259 ms) : 0, 9259
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.634 ms) : 0, 3634
IAST [baseline] (25.898 ms) : 0, 25898
IAST [candidate] (25.612 ms) : 0, 25612
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (803.469 ms) : 0, 803469
BytebuddyAgent [candidate] (799.802 ms) : 0, 799802
AgentMeter [baseline] (11.582 ms) : 0, 11582
AgentMeter [candidate] (11.582 ms) : 0, 11582
GlobalTracer [baseline] (249.671 ms) : 0, 249671
GlobalTracer [candidate] (248.445 ms) : 0, 248445
AppSec [baseline] (33.898 ms) : 0, 33898
AppSec [candidate] (34.182 ms) : 0, 34182
Debugger [baseline] (67.018 ms) : 0, 67018
Debugger [candidate] (66.545 ms) : 0, 66545
Remote Config [baseline] (545.64 µs) : 0, 546
Remote Config [candidate] (532.251 µs) : 0, 532
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.61 ms) : 0, 8610
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.417 ms) : 0, 3417
IAST [baseline] (27.375 ms) : 0, 27375
IAST [candidate] (27.388 ms) : 0, 27388
section profiling
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (680.302 ms) : 0, 680302
BytebuddyAgent [candidate] (682.195 ms) : 0, 682195
AgentMeter [baseline] (8.539 ms) : 0, 8539
AgentMeter [candidate] (8.517 ms) : 0, 8517
GlobalTracer [baseline] (215.492 ms) : 0, 215492
GlobalTracer [candidate] (216.027 ms) : 0, 216027
AppSec [baseline] (32.574 ms) : 0, 32574
AppSec [candidate] (32.704 ms) : 0, 32704
Debugger [baseline] (66.644 ms) : 0, 66644
Debugger [candidate] (67.293 ms) : 0, 67293
Remote Config [baseline] (623.245 µs) : 0, 623
Remote Config [candidate] (625.358 µs) : 0, 625
Telemetry [baseline] (9.049 ms) : 0, 9049
Telemetry [candidate] (8.899 ms) : 0, 8899
Flare Poller [baseline] (3.739 ms) : 0, 3739
Flare Poller [candidate] (3.759 ms) : 0, 3759
ProfilingAgent [baseline] (98.679 ms) : 0, 98679
ProfilingAgent [candidate] (99.129 ms) : 0, 99129
Profiling [baseline] (99.243 ms) : 0, 99243
Profiling [candidate] (99.702 ms) : 0, 99702
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (17.05 ms) : 16880, 17220
. : milestone, 17050,
appsec (18.701 ms) : 18512, 18890
. : milestone, 18701,
code_origins (18.568 ms) : 18383, 18753
. : milestone, 18568,
iast (17.661 ms) : 17487, 17834
. : milestone, 17661,
profiling (18.834 ms) : 18639, 19029
. : milestone, 18834,
tracing (17.93 ms) : 17751, 18109
. : milestone, 17930,
section candidate
no_agent (17.981 ms) : 17796, 18165
. : milestone, 17981,
appsec (18.646 ms) : 18457, 18834
. : milestone, 18646,
code_origins (18.704 ms) : 18514, 18894
. : milestone, 18704,
iast (17.805 ms) : 17630, 17981
. : milestone, 17805,
profiling (18.609 ms) : 18424, 18794
. : milestone, 18609,
tracing (17.489 ms) : 17312, 17666
. : milestone, 17489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.154 ms) : 3109, 3200
. : milestone, 3154,
iast_FULL (5.66 ms) : 5605, 5716
. : milestone, 5660,
iast_GLOBAL (3.53 ms) : 3464, 3595
. : milestone, 3530,
profiling (2.019 ms) : 2001, 2037
. : milestone, 2019,
tracing (1.817 ms) : 1802, 1832
. : milestone, 1817,
section candidate
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.068 ms) : 3032, 3104
. : milestone, 3068,
iast_FULL (5.684 ms) : 5627, 5740
. : milestone, 5684,
iast_GLOBAL (3.677 ms) : 3612, 3741
. : milestone, 3677,
profiling (2.211 ms) : 2191, 2231
. : milestone, 2211,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.76 ms) : 3539, 3980
. : milestone, 3760,
iast (2.243 ms) : 2174, 2312
. : milestone, 2243,
iast_GLOBAL (2.286 ms) : 2217, 2355
. : milestone, 2286,
profiling (2.066 ms) : 2012, 2121
. : milestone, 2066,
tracing (2.047 ms) : 1994, 2100
. : milestone, 2047,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.785 ms) : 3559, 4012
. : milestone, 3785,
iast (2.248 ms) : 2179, 2317
. : milestone, 2248,
iast_GLOBAL (2.282 ms) : 2212, 2351
. : milestone, 2282,
profiling (2.064 ms) : 2010, 2119
. : milestone, 2064,
tracing (2.043 ms) : 1990, 2096
. : milestone, 2043,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9479289f73, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
appsec (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
iast (17.942 s) : 17942000, 17942000
. : milestone, 17942000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
. : milestone, 17909000,
profiling (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
tracing (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
section candidate
no_agent (15.487 s) : 15487000, 15487000
. : milestone, 15487000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.421 s) : 18421000, 18421000
. : milestone, 18421000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (14.845 s) : 14845000, 14845000
. : milestone, 14845000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
|
d070b9a to
8bfae7a
Compare
25352eb to
55a6e24
Compare
amarziali
commented
Feb 19, 2026
raphaelgavache
approved these changes
Feb 19, 2026
| + (this.synthetics ? 1 : 0); | ||
|
|
||
| // Note: all the multiplication got constant folded at compile time (see javap -verbose ...) | ||
| int tmpHash = |
Contributor
There was a problem hiding this comment.
🎯 suggestion: Can it be a candidate to the new HashingUtils from @dougqh ?
Contributor
Author
There was a problem hiding this comment.
Well there is no signature for all the args afaik but indeed there is the addToHash facility that can be called repeatedly. I'll get an eye and if not in this PR, I'll open a followup if needed
Contributor
|
@codex review |
Contributor
|
(testing codex review output as part of DCS AI guild work) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55a6e24ed1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd-trace-core/src/main/java/datadog/trace/common/metrics/MetricKey.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/core/tagprocessor/TagsPostProcessorFactory.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9479289f73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd-trace-core/src/main/java/datadog/trace/core/tagprocessor/TagsPostProcessorFactory.java
Outdated
Show resolved
Hide resolved
PerfectSlayer
approved these changes
Feb 20, 2026
Base automatically changed from
andrea.marziali/serviename-integration
to
master
February 20, 2026 19:53
9479289 to
20abae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR continues the work begun by #10607 by adding the service name source to the stats.
The source is taking part to the bucket aggregation key and, if present, will be serialised under the
srv_srctag (see agent PR)This allows trace stats to carry additional context about service naming decisions without altering existing span behavior.
Also, the hashcode calculation in MetricsKey sounded not correct due to recent changes so I took the occasion to fix it and make more explicit by using constant folded multiplications
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.