Skip to content

0.11.0

  • 0.11.0
  • d51f3ad

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode

  • Choose a tag to compare

    View all tags
0.11.0: Don't Try to Set a Negative Frame Height (#96)
  • 0.11.0
  • d51f3ad

  • Choose a tag to compare

    View all tags

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
@thecoolwinter thecoolwinter tagged this 27 May 15:16 
### Description

Fixes a potential recursion where CETV tries to set it's frame to a negative number (due to overscroll & scroll inset weirdness). This adds a super simple sanity check to make sure we limit the textview to a `0` frame at minimum.

This hang would occur when no content is present, making the content size an odd number, which also makes scroll views freak out on macOS.

### Related Issues

* https://github.com/CodeEditApp/CodeEdit/issues/2049

### Checklist

- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

N/A, fixes a hang.
Assets 2
Loading