fix: add supported file loaders to detect the override file from upsert API#6375
Open
prd-hoang-doan wants to merge 1 commit into
Open
fix: add supported file loaders to detect the override file from upsert API#6375prd-hoang-doan wants to merge 1 commit into
prd-hoang-doan wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a list of supported file loaders and updates the server utilities to handle file storage overrides during the upsert process. It includes logic to correctly identify filenames from overrides and maps specific file loader parameters to a generic 'files' key for override validation. Feedback indicates that the node type check for file loaders is too restrictive and should be expanded to include specific file types like 'Pdf File'. Furthermore, several naming inconsistencies were identified in the SUPPORTED_FILE_LOADERS list that need to be aligned with the document loader components to ensure overrides function correctly for all file types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Root Cause:
Changes
vector/upsert/:uuidTesting
create_and_upsert_chatflow.mov
check_upsert_history.mov