ci: Add emulator tests (and related changes) for stalled API calls to control-client by gargnitingoogle · Pull Request #4566 · GoogleCloudPlatform/gcsfuse · GitHub

gargnitingoogle · 2026-04-02T09:23:54Z

Description

Add emulator tests (and related changes) for stalled API calls to control-client using the updated storage-testbench in feat: Add support for control-client stall support googleapis/storage-testbench#776 and feat: fix RenameFolder signature and implementation googleapis/storage-testbench#786 .
To make this change work fully, a new docker image needs to be crated for storage-testbench after feat: fix RenameFolder signature and implementation googleapis/storage-testbench#786 is merged, and uploaded to gcr.io/cloud-devrel-public-resources/storage-testbench.

Link to the issue in case of a bug fix.

b/493734599

Testing details

Manual - Tested locally by creating a local docker image using feat: fix RenameFolder signature and implementation googleapis/storage-testbench#786 and using that at

gcsfuse/tools/integration_tests/emulator_tests/emulator_tests.sh

Line 102 in 66fbbda

DEFAULT_IMAGE_NAME='gcr.io/cloud-devrel-public-resources/storage-testbench'

.
Unit tests - NA
Integration tests - To be run as presubmit once the update storage-testbench docker image is uploaded after feat: fix RenameFolder signature and implementation googleapis/storage-testbench#786 is merged.

Any backward incompatible change? If so, please explain.

codecov · 2026-04-06T09:50:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.67%. Comparing base (8b35120) to head (6970bad).

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4566       +/-   ##
===========================================
+ Coverage        0   83.67%   +83.67%     
===========================================
  Files           0      164      +164     
  Lines           0    20276    +20276     
===========================================
+ Hits            0    16966    +16966     
- Misses          0     2671     +2671     
- Partials        0      639      +639

Flag	Coverage Δ
unittests	`83.67% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…point

- Added integration test suite to verify experimental stall retry logic for CreateFolder, GetFolder, DeleteFolder, RenameFolder, and GetStorageLayout. - Refactored test setup to utilize individual suite structures per API method, enabling isolated proxy config dynamic loading. - Validated that operations successfully complete within the 31s client timeout. - Validated that GetStorageLayout correctly completes the mount under 40s despite an artificial 60s stall limit specifically targeting its initial call. - Excluded ListFolders as GCSFuse internally relies on ListObjects instead of ListFolders for folder iteration. - Cleaned up unused multi-method proxy configurations. - Cleaned up setup_test.go by moving global mounting state into the test suite struct to guarantee test isolation. - Updated to use non-deprecated metadata cache TTL flags.

gemini-code-assist · 2026-04-09T06:39:49Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust testing capabilities for the control-client by implementing emulator tests that simulate stalled API calls. These changes ensure that the experimental retry logic for folder operations and storage layout retrieval functions correctly under adverse network conditions. Additionally, the infrastructure for the gRPC proxy server was enhanced to support instruction injection, and existing tests were updated to maintain stability during the transition to these new testing patterns.

Highlights

Emulator Test Infrastructure: Added comprehensive emulator tests to verify the retry logic for stalled API calls in the control-client, utilizing the updated storage-testbench.
Control Client Configuration: Updated the storage handle initialization to enable the control client even when using local endpoints, ensuring consistent behavior for testing.
Proxy Server Enhancements: Updated the gRPC proxy server to support injecting testbench instructions via metadata, allowing for the simulation of stalled API calls.
Test Suite Adjustments: Disabled Hierarchical Namespace (HNS) in existing emulator tests to prevent compatibility issues with the legacy HTTP/1.1 proxy server.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-04-15T04:28:59Z