feat: Support rapid appends for rw/w/w+ file open modes#4613
Draft
kislaykishore wants to merge 3 commits intomasterfrom
Draft
feat: Support rapid appends for rw/w/w+ file open modes#4613kislaykishore wants to merge 3 commits intomasterfrom
kislaykishore wants to merge 3 commits intomasterfrom
Conversation
* Indicate that the premature-EOF/incorrect data reads can happen for versions older than 3.0. * Remove disabling-streaming-writes from the list of workarounds.
When opening a file in a write-capable mode (O_WRONLY or O_RDWR), bypass the redundant StatObject call for zonal buckets when EnableRapidAppends is true. Previously, this optimization was only applied to O_APPEND modes. This change broadens the scope to allow buffered writes to be initialized for workflows that open files for writing, seek to the end, and write without explicitly using append modes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
- Coverage 83.67% 83.66% -0.01%
==========================================
Files 164 164
Lines 20215 20217 +2
==========================================
+ Hits 16914 16915 +1
- Misses 2664 2665 +1
Partials 637 637
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a file in a write-capable mode (O_WRONLY or O_RDWR), bypass the redundant StatObject call for zonal buckets when EnableRapidAppends is true.
Previously, this optimization was only applied to explicitly opened O_APPEND modes. This change broadens the scope to allow buffered writes to be initialized for workflows that open files for writing, seek to the end, and write without explicitly using append modes (a common pattern for database workloads).