Merge java version into master#30
Open
Mkerian10 wants to merge 3 commits into
Open
Conversation
Initial commit of Java files.
Owner
|
Thanks @Mkerian10 for the hard work. Generally they look good to me. Just a few change requests, and then I'll merge this PR: I see some binary files committed, as well as many cache files, history files and lock files. Do you think they should be deleted? The other request is that can you change the package name from evaluator to phevaluator? So that the name matches the Python package name and C++ namespace. |
|
None of the files in .gradle should be merged, those are local build files that appear to have been committed by accident. Same with the folder gradle/wrapper. Only the file java/build.gradle and the folder java/src (and all files and subdirectories of java/src) should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds java version, doing 5-9 card evaluation. Addresses issue #5