fix(gateway): update Podman supervisor build task name#1288
Open
russellb wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(gateway): update Podman supervisor build task name#1288russellb wants to merge 1 commit intoNVIDIA:mainfrom
russellb wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The Podman path in the dev gateway script references the build:docker:supervisor-sideload mise task, which was removed in d8b8477 ("feat(rpm): add RPM packaging with Packit/COPR and GHA release publishing (NVIDIA#1126)"). That commit consolidated the sideload and standalone supervisor image builds into a single build:docker:supervisor task. Update the reference so `mise run gateway` works with the Podman compute driver. Signed-off-by: Russell Bryant <russell.bryant@gmail.com>
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Podman path in the dev gateway script which references the removed
build:docker:supervisor-sideloadmise task, causingmise run gatewayto fail when Podman is the detected compute driver.Related Issue
Broken by d8b8477 ("feat(rpm): add RPM packaging with Packit/COPR and GHA release publishing (#1126)"), which consolidated the sideload and standalone supervisor image builds into a single
build:docker:supervisortask but did not update the gateway script.Changes
tasks/scripts/gateway.shto referencebuild:docker:supervisorinstead of the removedbuild:docker:supervisor-sideloadTesting
mise run pre-commitpasses (pre-existingpython:protofailure on main, unrelated)mise run gatewaysucceeds with Podman driverChecklist