Investigate and propose fix for issue 126#128
Merged
Antoine-lb merged 2 commits intoSep 21, 2025
Conversation
Co-authored-by: antoine.stc25 <antoine.stc25@gmail.com>
|
Cursor Agent can help with this pull request. Just |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| */ | ||
| private isVideoFile(filepath: string): boolean { | ||
| return filepath.toLowerCase().match(/\.(mp4|webm|ogg)$/) !== null; | ||
| } |
There was a problem hiding this comment.
Bug: ExifIO Video Recognition Mismatch
The ExifIO.isVideoFile method only recognizes mp4, webm, and ogg files. This is inconsistent with the isFileExtensionVideo function used in the UI. For video files outside this limited set, ExifIO will attempt to read image dimensions, leading to incorrect or missing dimensions.
Co-authored-by: antoine.stc25 <antoine.stc25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix video playback and "EXIF data error" by correctly handling video metadata extraction and DOM events.
Previously, video files were processed using image-specific EXIF fields and relied on the
onloadevent for dimension detection, which videos do not fire. This led to videos failing to load, displaying a generic "EXIF data error", and preventing playback in slide mode. This PR introduces video-specific metadata field parsing and uses the correctonloadedmetadataevent, along with improved error fallbacks and user-facing messages.