Improve documents for Connection class arguments use_unicode and charset#345
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 13 13
Lines 1556 1556
=======================================
Hits 1356 1356
Misses 200 200
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 13 13
Lines 1556 1556
=======================================
Hits 1356 1356
Misses 200 200
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pull request aims for improving documents for
Connectionclass argumentsuse_unicodeandcharset:use_unicodeuse_unicodeis set to False on Python 2 and True on Python 3 by default, and the fact thatcharsetdoes not implyuse_unicodebut changes its default value. The worldimpliesmight be misleading for developers who did not see the code.OT I noticed that the upstream project https://github.com/farcepest/MySQLdb1 hasn't been updated for a long time(maybe not in maintenance, sad), so I decided to pull request here :)