fix(devtools): add transform: translateZ(0) for Safari overflow rendering#10638
fix(devtools): add transform: translateZ(0) for Safari overflow rendering#10638lihan3238 wants to merge 1 commit intoTanStack:mainfrom
Conversation
…ring Safari has a known issue where overflow: hidden with border-radius doesn't work correctly without hardware acceleration. Adding transform: translateZ(0) forces GPU compositing which fixes the icon rendering issue. Fixes TanStack#10633
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded GPU hardware acceleration CSS properties ( ChangesDevTools Button Styling Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ErikPervious
left a comment
There was a problem hiding this comment.
Classic Safari hack — forces a compositor layer to fix overflow rendering quirks. Worked for similar cases I've hit. LGTM as a targeted fix.
Summary
Safari has a known issue where
overflow: hiddenwithborder-radiusdoesn't work correctly without hardware acceleration. This causes the devtools icon to render incorrectly in Safari.Changes
Added
transform: translateZ(0)and-webkit-transform: translateZ(0)to the background div element to force GPU compositing, which fixes the overflow rendering issue in Safari.Fixes #10633
Test plan
Summary by CodeRabbit