This repository was archived by the owner on Aug 27, 2025. It is now read-only.
[master] (fix) ZIL-5144: Don't send Scilla contract creation to ARCHIVAL_SEND_…#3530
Merged
Merged
Conversation
…SHARD unless you are actually a lookup or archival node.
Contributor
|
The purpose of sending to shards rather than DS is to scale them. contract creation, esp in Scilla should be so much more rare than contract calls that an advantage to scaling it through sharding almost doesn't exist. At some point, we had unified this among EVM and Scilla, and had sent all creation to DS. In the current codebase you are fixing, it seems it is no longer the case (don't know when it reverted back). Anyhow, the change LGTM, but FWIW sending them to shards is not necessary at all. |
valeryz
approved these changes
Mar 30, 2023
5 tasks
Contributor
Author
|
Merged 3530 on the basis that we can then decide to merge 3532 over it - before I OK that one, I want to see it pass some tests. Before that, I want to be able to run some tests! Sorry @valeryz ... |
JamesHinshelwood
pushed a commit
that referenced
this pull request
Apr 4, 2023
…SHARD unless you are actually a lookup or archival node. (#3530)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…SHARD unless you are actually a lookup or archival node.
Description
Fix ZIL-5144.
Backward Compatibility
Review Suggestion
Check that the logic is correct - please be careful; this is my first PR which touches actual logic and I'm far from sure I have it right - the only evidence I have is traces and the fact that my trivial deploy-a-Scilla-contract test works with this patch, and fails without it.