Skip to content

Bug fix: the component is removed,But the event handler registered is…#14

Merged
kopach merged 2 commits into
a7ul:masterfrom
winnieBear:master
Aug 24, 2021
Merged

Bug fix: the component is removed,But the event handler registered is…#14
kopach merged 2 commits into
a7ul:masterfrom
winnieBear:master

Conversation

@winnieBear
Copy link
Copy Markdown

fix bug: when the component is removed,But the event handler registered is still running.see Issue #13
Here is a demo: https://github.com/winnieBear/demo-show-react-webcomponentify-bug

@kopach
Copy link
Copy Markdown
Collaborator

kopach commented Aug 19, 2021

Will this work also with Functional components (noting will break)? As well as components with React.memo?

@kopach
Copy link
Copy Markdown
Collaborator

kopach commented Aug 24, 2021

Hi @winnieBear, thanks for your contribution. I've tested this in sandbox, and it works just fine.
Just for reference,

@kopach kopach merged commit fa0ef63 into a7ul:master Aug 24, 2021
@kopach kopach self-requested a review August 24, 2021 07:45
@kopach
Copy link
Copy Markdown
Collaborator

kopach commented Aug 24, 2021

@a7ul, feel free to release this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants