Skip to content

Add test protocol to validate resolution #6#29

Merged
TG1999 merged 8 commits into
mainfrom
test-protocol
Jul 7, 2022
Merged

Add test protocol to validate resolution #6#29
TG1999 merged 8 commits into
mainfrom
test-protocol

Conversation

@pombredanne
Copy link
Copy Markdown
Member

This PR provides a base documentation to validate dependency resolution.

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne requested review from mjherzog and tdruez June 24, 2022 18:14
@pombredanne
Copy link
Copy Markdown
Member Author

@TG1999 Can you help me make it pass the tests?

@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Jun 24, 2022

Sure @pombredanne , on it!

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Jun 24, 2022

@pombredanne All green now!

@pombredanne pombredanne requested review from TG1999 and removed request for tdruez June 24, 2022 21:05
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Copy Markdown
Member Author

@TG1999 the steps would benefit a lot from an actual end to end example.I added a starter for this but your review and help to complete this would be awesome!

@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Jun 28, 2022

Sure @pombredanne will work on this part!

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the test-protocol branch 5 times, most recently from dd32710 to 87ecd26 Compare July 2, 2022 21:31
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Copy Markdown
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Copy Markdown
Member Author

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit db336bd into main Jul 7, 2022
@TG1999 TG1999 deleted the test-protocol branch July 11, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants