Skip to content

Add a new option --json-pdt#44

Merged
TG1999 merged 5 commits into
mainfrom
pdt
Jul 29, 2022
Merged

Add a new option --json-pdt#44
TG1999 merged 5 commits into
mainfrom
pdt

Conversation

@TG1999
Copy link
Copy Markdown
Contributor

@TG1999 TG1999 commented Jul 22, 2022

This option emulates the output pipdeptree.
closes #37

Copy link
Copy Markdown
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See inline comments

Comment thread src/python_inspector/resolution.py
Comment thread src/python_inspector/resolution.py Outdated
@TG1999 TG1999 force-pushed the pdt branch 2 times, most recently from 1b6013d to 1b3dd66 Compare July 28, 2022 15:03
TG1999 added 2 commits July 29, 2022 18:36
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Copy Markdown
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See a few nits for your consideration.

Comment thread src/python_inspector/resolution.py
Comment thread src/python_inspector/resolution.py Outdated
Comment thread src/python_inspector/resolution.py Outdated
Comment thread src/python_inspector/resolution.py Outdated
Comment thread src/python_inspector/resolution.py
Comment thread src/python_inspector/resolve_cli.py Outdated
Comment thread src/python_inspector/resolve_cli.py Outdated
Comment thread src/python_inspector/resolve_cli.py Outdated
Comment thread src/python_inspector/resolve_cli.py Outdated
Comment thread src/python_inspector/resolve_cli.py Outdated
Co-authored-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 requested a review from pombredanne July 29, 2022 16:07
Copy link
Copy Markdown
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge

@TG1999 TG1999 merged commit 226260d into main Jul 29, 2022
@pombredanne pombredanne deleted the pdt branch August 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new option --json-pdt

2 participants