Add sap-hana-cli plugin#1616
Conversation
|
can we rename this to sap-hana-cli? |
25c68b8 to
6de1dd5
Compare
cd62e20 to
d04d17b
Compare
|
@tobinsouth please review |
207c7d7 to
7731f85
Compare
Klaus-Keller
left a comment
There was a problem hiding this comment.
@bryan-anthropic, changes are fine for @sap-ux/fiori-mcp-server.
We even thought about changing to "name": "sap-fiori-mcp-server" at
https://github.com/SAP/open-ux-tools/blob/534227c1fd0fc75c82710a0c6918105b1b890652/packages/fiori-mcp-server/.claude-plugin/plugin.json#L2
for consistency reasons.
| }, | ||
| { | ||
| "name": "sap-cds-mcp", | ||
| "description": "AI-assisted development of SAP Cloud Application Programming Model (CAP) projects. Search CDS models and CAP documentation.", |
There was a problem hiding this comment.
@bryan-anthropic There is a duplicate entry. So, "cds-mcp" and "sap-cds-mcp" are actually the same.
There was a problem hiding this comment.
Good catch — dropped cds-mcp in 0a71f74; sap-cds-mcp is now the single CAP entry.
Per upstream review on PR #1616 — cds-mcp and sap-cds-mcp were the same plugin. Dropping the unprefixed entry consolidates under the SAP namespace. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Holding off on approval — a few things to sort out before this can land cleanly under the new validator:
Happy to re-review once those are addressed. |
|
Addressed all 3 points in b190323:
Updated the PR body to accurately describe the additive scope. Ready for re-review. |
b190323 to
ecd3688
Compare
|
Rebased onto current main (force-push: `b190323` → `ecd3688`). |
|
`validate` is failing on `sap-hana-cli` due to an upstream plugin.json schema bug — the developer's plugin.json uses the npm-style `{type, url}` object form for `repository`, but Claude's schema requires a string. Filed an upstream fix: SAP-samples/hana-cli-claude-plugin#2 Will hold this PR until that lands, then bump the `sap-hana-cli` SHA pin and re-run CI. The other 2 new entries (`sap-cds-mcp`, `sap-fiori-mcp-server`) and the 4 author-block updates are all valid. |
|
SAP requested that we ship `sap-fiori-mcp-server` ahead of the rest. Split it out into #1777 — that one already validates cleanly and can land independently. This PR (#1616) remains on hold for the `sap-hana-cli` upstream fix (`SAP-samples/hana-cli-claude-plugin#2`). When that merges, I'll bump the SHA pin here and re-run CI. The remaining changes here will be: `cds-mcp` author block, `sap-cds-mcp` (new), `sap-hana-cli` (new), `sap-mdk-server` author block expansion, `ui5` + `ui5-typescript-conversion` author blocks. |
150+ SAP HANA database tools for AI assistants. Pinned at 160ae47e. Held: this PR is on hold pending an upstream plugin.json fix in SAP-samples/hana-cli-claude-plugin#2 (the upstream repo uses the npm-style {type, url} form for `repository`; Claude's plugin schema requires the string form). Once that lands, bump the SHA pin here to the merge commit and re-run CI. Other SAP namespace work that was previously bundled in this PR has been split into: - #1777 add sap-fiori-mcp-server - #1778 add sap-cds-mcp + author block on cds-mcp - #1779 align SAP author blocks on sap-mdk-server, ui5, ui5-typescript-conversion
ecd3688 to
13ed4bf
Compare
|
Scoped this PR back to just `sap-hana-cli`. The other 6 changes that were bundled here have been split into independent PRs so they can land without waiting on the upstream hana-cli fix:
This PR remains held on `SAP-samples/hana-cli-claude-plugin#2`. Force-pushed the branch (`ecd3688` → `13ed4bf`) so the diff now shows only the single `sap-hana-cli` insertion (+16 / −0). |
Metadata-only refresh per the SAP namespace policy (Florian/Klaus/Avital,
2026-05-04). No slug renames, no new entries.
- sap-mdk-server: expand author from {"name":"SAP"} to the unified
SAP SE block with ospo@sap.com.
- ui5: add unified UI5 author block (openui5@sap.com per Florian's
carve-out for the SAPUI5/OpenUI5 brand).
- ui5-typescript-conversion: same UI5 author block as ui5.
Split out of #1616 to keep that PR scoped to sap-hana-cli only.
CAP CDS work as one cohesive unit, split out of #1616 to keep that PR narrowly scoped to sap-hana-cli (which is currently held on an upstream plugin.json fix). - Adds new sap-cds-mcp entry alongside existing cds-mcp (additive, non-breaking — both point to cap-js/mcp-server). Pinned at 8ce2e13a. - Adds the unified SAP SE author block to existing cds-mcp. Per the SAP namespace policy agreed with SAP (Tobin 2026-04-29 + Florian/Klaus/Avital 2026-05-04 email).
CAP CDS work as one cohesive unit, split out of #1616 to keep that PR narrowly scoped to sap-hana-cli (which is currently held on an upstream plugin.json fix). - Adds new sap-cds-mcp entry alongside existing cds-mcp (additive, non-breaking — both point to cap-js/mcp-server). Pinned at 8ce2e13a. - Adds the unified SAP SE author block to existing cds-mcp. Per the SAP namespace policy agreed with SAP (Tobin 2026-04-29 + Florian/Klaus/Avital 2026-05-04 email).
Add
sap-hana-clito the marketplace.150+ SAP HANA database tools for AI assistants — query tables, import/export data, profile data quality, compare schemas, manage backups, monitor performance, etc. Connects to SAP HANA Cloud and on-premise databases.
160ae47e(current HEAD)Held on upstream fix
This PR is on hold pending SAP-samples/hana-cli-claude-plugin#2 — the upstream
plugin.jsonuses the npm-style{type, url}object form forrepository; Claude's plugin schema requires the string form. Once that lands, thesap-hana-cliSHA pin here will be bumped to the merge commit and CI re-run.Scope
This PR was previously bundled with the rest of the SAP namespace alignment work. To unblock the other entries, that work has been split into separate PRs:
sap-fiori-mcp-serversap-cds-mcp+ author block oncds-mcpsap-mdk-server,ui5,ui5-typescript-conversionPer the SAP namespace policy (Tobin 2026-04-29 + Florian/Klaus/Avital 2026-05-04). Additive non-breaking — no slug renames or deletions.