Skip to content

Vue Dialog: unwrap MaybeRef props before cleanProps in useDialog#3876

Merged
segunadebayo merged 3 commits intomainfrom
copilot/fix-cleanprops-computedref-issue
May 8, 2026
Merged

Vue Dialog: unwrap MaybeRef props before cleanProps in useDialog#3876
segunadebayo merged 3 commits intomainfrom
copilot/fix-cleanprops-computedref-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026 •
edited
Loading

  • Review PR feedback and inspect current branch state
  • Audit Vue composables for similar cleanProps + ref/computed unwrapping issues
  • Apply any additional minimal code fixes if similar issues are found
  • Add a changeset for the Vue fix
  • Run targeted tests for affected Vue components
  • Run final validation and reply to PR comment

Copilot AI linked an issue May 8, 2026 that may be closed by this pull request
[Vue] cleanProps(props) in useXxx composables fails to unwrap ComputedRef, silently dropping all user props #3875
Closed
4 tasks
@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ark-docs Ready Ready Preview May 8, 2026 1:22pm

Request Review

Copilot AI changed the title [WIP] Fix cleanProps to correctly unwrap ComputedRef in useXxx composables Vue Dialog: unwrap MaybeRef props before cleanProps in useDialog May 8, 2026
Copilot AI requested a review from segunadebayo May 8, 2026 12:01
@segunadebayo
Copy link
Copy Markdown
Member

segunadebayo commented May 8, 2026

@copilot add a changeset to this PR. Also check if there are other similar issues like this and fix them.

@segunadebayo
chore: add changeset for vue dialog computed props fix
42e35f1 
Agent-Logs-Url: https://github.com/chakra-ui/ark/sessions/e29dbbdb-7233-4f66-8bcf-ac255263dc95

Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

@copilot add a changeset to this PR. Also check if there are other similar issues like this and fix them.

Added a changeset in .changeset/fuzzy-comics-behave.md and pushed it in commit 42e35f1. I also audited Vue composables for the same pattern; useDialog was the only useXxx case using wrapped props with cleanProps, and the others already pass unwrapped localProps/localeProps.

@segunadebayo segunadebayo marked this pull request as ready for review May 8, 2026 13:25
@segunadebayo segunadebayo merged commit 4019c8b into main May 8, 2026
1 check passed
@segunadebayo segunadebayo deleted the copilot/fix-cleanprops-computedref-issue branch May 8, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@segunadebayo segunadebayo Awaiting requested review from segunadebayo

Assignees

@segunadebayo segunadebayo

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Vue] cleanProps(props) in useXxx composables fails to unwrap ComputedRef, silently dropping all user props

2 participants

@segunadebayo