Skip to content

Add LTL past operator#5260

Merged
fabianschuiki merged 1 commit into
mainfrom
fschuiki/ltl-past
Apr 9, 2026
Merged

Add LTL past operator#5260
fabianschuiki merged 1 commit into
mainfrom
fschuiki/ltl-past

Conversation

@fabianschuiki
Copy link
Copy Markdown
Contributor

CIRCT has recently gained the circt.ltl.past FIRRTL intrinsic which allows us to emit $past expressions in SystemVerilog assertions. Add a corresponding Sequence.past(...) operator, which allows the user to refer to past values of a sequence, optionally with a cycle delay != 1, and optionally with an explicit clock instead of the one inferred for the sequence.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@fabianschuiki fabianschuiki added the Feature New feature, will be included in release notes label Apr 8, 2026
Comment thread src/main/scala-2/chisel3/ltl/LTLIntf.scala Outdated
Comment thread src/test/scala/chiselTests/LTLSpec.scala
Copy link
Copy Markdown
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a couple of nits to consider but non-blocking

CIRCT has recently gained the `circt.ltl.past` FIRRTL intrinsic which
allows us to emit `$past` expressions in SystemVerilog assertions. Add
a corresponding `Sequence.past(...)` operator, which allows the user to
refer to past values of a sequence, optionally with a cycle delay != 1,
and optionally with an explicit clock instead of the one inferred for
the sequence.
@fabianschuiki fabianschuiki enabled auto-merge (squash) April 9, 2026 15:59
@fabianschuiki fabianschuiki merged commit 8a28062 into main Apr 9, 2026
28 checks passed
@fabianschuiki fabianschuiki deleted the fschuiki/ltl-past branch April 9, 2026 16:12
fabianschuiki added a commit that referenced this pull request Apr 9, 2026
Follow-up to #5260. Use proper ScalaDoc references in the doc comments
of the LTL package. And switch the LTLSpec test over to use FileCheck.
fabianschuiki added a commit that referenced this pull request Apr 9, 2026
Follow-up to #5260. Use proper ScalaDoc references in the doc comments
of the LTL package. And switch the LTLSpec test over to use FileCheck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants