Add LTL past operator#5260
Merged
Merged
Conversation
jackkoenig
reviewed
Apr 9, 2026
jackkoenig
reviewed
Apr 9, 2026
jackkoenig
approved these changes
Apr 9, 2026
Contributor
jackkoenig
left a comment
There was a problem hiding this comment.
Overall looks good, a couple of nits to consider but non-blocking
CIRCT has recently gained the `circt.ltl.past` FIRRTL intrinsic which allows us to emit `$past` expressions in SystemVerilog assertions. Add a corresponding `Sequence.past(...)` operator, which allows the user to refer to past values of a sequence, optionally with a cycle delay != 1, and optionally with an explicit clock instead of the one inferred for the sequence.
0646740 to
202e8f0
Compare
fabianschuiki
added a commit
that referenced
this pull request
Apr 9, 2026
Follow-up to #5260. Use proper ScalaDoc references in the doc comments of the LTL package. And switch the LTLSpec test over to use FileCheck.
14 tasks
fabianschuiki
added a commit
that referenced
this pull request
Apr 9, 2026
Follow-up to #5260. Use proper ScalaDoc references in the doc comments of the LTL package. And switch the LTLSpec test over to use FileCheck.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIRCT has recently gained the
circt.ltl.pastFIRRTL intrinsic which allows us to emit$pastexpressions in SystemVerilog assertions. Add a correspondingSequence.past(...)operator, which allows the user to refer to past values of a sequence, optionally with a cycle delay != 1, and optionally with an explicit clock instead of the one inferred for the sequence.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.