Skip to content

Add explicit CODEOWNERS rule for /src/content/partials/load-balancing/#30975

Merged
diogoascarneiro merged 1 commit into
productionfrom
ncrouch/codeowners/load-balancing-partials
May 21, 2026
Merged

Add explicit CODEOWNERS rule for /src/content/partials/load-balancing/#30975
diogoascarneiro merged 1 commit into
productionfrom
ncrouch/codeowners/load-balancing-partials

Conversation

@ncrouch-cflare
Copy link
Copy Markdown
Collaborator

Summary

Adds an explicit CODEOWNERS rule for /src/content/partials/load-balancing/ mirroring the owners of /src/content/docs/load-balancing/:

/src/content/partials/load-balancing/ @cloudflare/cf1-reviewers @elithrar @cloudflare/product-owners @ncrouch-cflare

Why

Today, load-balancing partials fall through to the top-level default rule (* @cloudflare/product-owners), which means PRs that touch both docs/load-balancing/ and partials/load-balancing/ require approvals from two different sets of reviewers — even though the same Load Balancing team owns both. For example, #30938 touches both, and my approval as a named code owner on /docs/load-balancing/ does not satisfy the default rule that covers the partials file.

This is consistent with how other products handle their partials — /src/content/partials/r2/, /src/content/partials/d1/, /src/content/partials/workers/, /src/content/partials/hyperdrive/, etc. all have explicit rules that match (or extend) their corresponding docs/ rule.

Documentation checklist

  • No changelog entry needed (CODEOWNERS-only change, no customer-facing docs).
  • No style-guide impact.
  • No redirects needed.

Mirror the /src/content/docs/load-balancing/ rule for /src/content/partials/load-balancing/ so PRs touching load-balancing partials no longer fall through to the default '* @cloudflare/product-owners' rule.

This is consistent with how other products handle their partials (e.g., /src/content/partials/r2/, /src/content/partials/d1/, /src/content/partials/workers/ all have explicit rules) and lets the same set of reviewers approve docs and partials together.
@github-actions
Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/CODEOWNERS @cloudflare/product-owners, @cloudflare/content-engineering, @kodster28

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 20, 2026

No issues found. The new rule mirrors the existing docs ownership, is placed correctly within the Performance products section, and matches the pattern used by other products.

@ask-bonk ask-bonk Bot added product:load-balancing Related to Load Balancing product engineering Problems or updates to developers.cloudflare.com website labels May 20, 2026
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 20, 2026

PR #30975 review complete.

Labels applied: product:load-balancing, size/xs, engineering

Summary:
Adds one line to .github/CODEOWNERS assigning /src/content/partials/load-balancing/ the same owners as /src/content/docs/load-balancing/. This ensures PRs that touch both the docs and partials for Load Balancing only require approval from the Load Balancing team, instead of falling back to the top-level default rule and requiring a second set of reviewers.

Issues flagged: None. The rule is syntactically correct, placed immediately after the corresponding docs/ rule in the Performance products section, and follows the established pattern used by other products (R2, D1, Workers, Hyperdrive, etc.). I also verified that src/content/partials/load-balancing/ exists and contains 42 partial files, confirming the rule is actively needed.

Verdict: Ready to merge.

github run

@github-actions
Copy link
Copy Markdown
Contributor

@diogoascarneiro diogoascarneiro merged commit aae6207 into production May 21, 2026
19 checks passed
@diogoascarneiro diogoascarneiro deleted the ncrouch/codeowners/load-balancing-partials branch May 21, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Problems or updates to developers.cloudflare.com website product:load-balancing Related to Load Balancing product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants