Align receipt canonicalization/status and remove legacy ENS verify shim#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
json.sorted_keys.v1routine.statusenum to the runtime value"success".Description
src/ens.verify.ts) and removed its export fromsrc/index.tsso the malformed default TXT key is not shipped.canonicalizeReceiptwith a call tocanonicalizeSortedKeysV1by importing it insrc/receipt.tsto unify canonicalization logic.ReceiptStatustype insrc/types.tsfrom"ok" | "error"to"success" | "error"and updated tests and README examples to use"success".package-lock.json, removed it from.gitignore, and rebuilt distribution artifacts underdist/so the package output remains consistent for publishing.Testing
npm installsuccessfully to populate dependencies.npm test(which runstscas part of the pipeline) and all automated tests passed.Codex Task