Skip to content

Purge openresty#14353

Merged
MickLesk merged 1 commit into
community-scripts:mainfrom
lucacome:openresty
May 9, 2026
Merged

Purge openresty#14353
MickLesk merged 1 commit into
community-scripts:mainfrom
lucacome:openresty

Conversation

@lucacome
Copy link
Copy Markdown
Contributor

@lucacome lucacome commented May 9, 2026

✍️ Description

Just removing openresty leaves behind the configuration and makes if dpkg -s openresty &>/dev/null 2>&1; then always true, making it reinstall openresty every time.

🔗 Related Issue

#14352

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@lucacome lucacome requested a review from a team as a code owner May 9, 2026 00:11
@github-actions github-actions Bot added update script A change that updates a script bugfix labels May 9, 2026
Copy link
Copy Markdown
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MickLesk MickLesk merged commit 7b7aece into community-scripts:main May 9, 2026
6 checks passed
@lucacome lucacome deleted the openresty branch May 9, 2026 18:50
@andreibuzatu
Copy link
Copy Markdown

Hey, just wanted to report an issue I hit after updating the Nginx Proxy Manager LXC with the changes from PR #14353.

After the update, NPM stopped working because OpenResty came up with the default nginx.conf instead of the usual NPM config. Port 81 was no longer listening, the admin UI was down, and none of the proxy configs were being loaded.

When I checked /usr/local/openresty/nginx/conf/nginx.conf, it had been replaced with the stock OpenResty example config instead of the NPM one.

I managed to fix it manually by rebuilding the missing config entries, but it looks like the migration to source-built OpenResty is overwriting the original NPM bootstrap config during updates.

@MickLesk
Copy link
Copy Markdown
Member

Create an issue and Not inside of a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants