Skip to content

dap: fix skipped breakpoint when the breakpoint and the entrypoint were the same#3691

Merged
tonistiigi merged 1 commit intodocker:masterfrom
jsternberg:dap-entrypoint-breakpoint
Mar 17, 2026
Merged

dap: fix skipped breakpoint when the breakpoint and the entrypoint were the same#3691
tonistiigi merged 1 commit intodocker:masterfrom
jsternberg:dap-entrypoint-breakpoint

Conversation

@jsternberg
Copy link
Copy Markdown
Collaborator

We erroneously skipped a breakpoint when that breakpoint was the same as
the entrypoint and we did not use stop on entry. This is because we only
started evaluating breakpoints after the first step on the entrypoint
instead of at the entrypoint.

Comment thread tests/dap_build.go Outdated
Comment thread tests/dap_build.go
…re the same

We erroneously skipped a breakpoint when that breakpoint was the same as
the entrypoint and we did not use stop on entry. This is because we only
started evaluating breakpoints after the first step on the entrypoint
instead of at the entrypoint.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg jsternberg force-pushed the dap-entrypoint-breakpoint branch from e5aff80 to 724afbb Compare March 11, 2026 15:53
@crazy-max crazy-max added this to the v0.33.0 milestone Mar 13, 2026
@tonistiigi tonistiigi merged commit 19258b1 into docker:master Mar 17, 2026
159 checks passed
@jsternberg jsternberg deleted the dap-entrypoint-breakpoint branch March 17, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants