Finish secret redaction#2589
Merged
dgageot merged 3 commits intodocker:mainfrom Apr 29, 2026
Merged
Conversation
Member
dgageot
commented
Apr 29, 2026
- Make sure to redact tool call's output too
- Make sure we can replicate the top level configuration with hooks configuration
…nsform hook The recent commits added a third leg to redact_secrets (tool output) and exposed all three legs as first-class hook entries via the new tool_response_transform event. Update the docs to match: - docs/configuration/hooks: add tool_response_transform to the events table, the per-event extra-fields table, and a new "Tool-Response-Transform Specific Output" subsection documenting hook_specific_output.updated_tool_response. Update the redact_secrets builtin row and the auto-injected callout to reflect that the same builtin now covers pre_tool_use, before_llm_call, and tool_response_transform. - docs/configuration/agents: update the redact_secrets field description, the YAML schema sketch, and the "Redacting Secrets" section to enumerate three defenses. Rewrite the equivalent-hook callout to point at examples/redact_secrets_hooks.yaml and explain the manual wiring. - docs/guides/secrets: extend the redact_secrets bullet list with the tool-output leg. Assisted-By: docker-agent
rumpl
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.