feat(hooks): expose stop hook via CLI#2627
Merged
derekmisler merged 1 commit intodocker:mainfrom May 4, 2026
Merged
Conversation
- Add a repeatable `--hook-stop` flag that registers shell commands fired by the existing upstream `EventStop` hook (defined in `pkg/hooks/types.go` as "fires when the model finishes its response")
- The hook event itself is already wired into the executor; this PR only plumbs the CLI surface, mirroring the existing `--hook-pre-tool-use`, `--hook-post-tool-use`, `--hook-session-{start,end}`, `--hook-on-user-input` flags
- Threads the new entry through `RuntimeConfig.HookStop`, `HooksFromCLI`, `CLIHooks`, and `Clone`; tests updated to cover both the new flag and the clone-copy path
derekmisler
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a case where we need to capture event when model finishes responding. There's already existing
stophook for that, but it's not exposed via CLI.