Skip to content

Fix Uri.GetHashCode hash/equality contract violation for file: URIs #124652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Draft

Fix Uri.GetHashCode hash/equality contract violation for file: URIs #124652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e30c7
Initial plan
Copilot Feb 20, 2026
b53c9f7
Fix Uri.GetHashCode to use OrdinalIgnoreCase for all file: URIs, not …
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.Uri/src/System/Uri.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ public override int GetHashCode()

string remoteUrl = info.RemoteUrl ??= GetParts(components, UriFormat.SafeUnescaped);

if (IsUncOrDosPath)
if (IsFile)
{
return StringComparer.OrdinalIgnoreCase.GetHashCode(remoteUrl);
}
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Private.Uri/tests/FunctionalTests/UriMethodsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,9 @@ public static IEnumerable<object[]> Equals_TestData()
yield return new object[] { new Uri("file://C:/path1/path2/file"), new Uri("http://domain.com"), false };
yield return new object[] { new Uri("file://C:/path1/path2/file"), new Uri(@"\\server\path1\path2\file"), false };

// UNC paths that normalize to the same value as a regular file: URI
yield return new object[] { new Uri("\\\\\u202a"), new Uri("file:///"), true };

// UNC share paths
yield return new object[] { new Uri(@"\\server\sharepath\path\file"), new Uri(@"\\server\sharepath\path\file"), true };
yield return new object[] { new Uri(@"\\server\sharepath\path\file"), new Uri(@"\\server1\sharepath\path\file"), false };
Expand Down
Loading