-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Move diagnostics out of JSImportGenerator and JSExportGenerator into a separate analyzer #124671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9695918
Initial plan
Copilot 93edf15
Move diagnostics out of JSImportGenerator and JSExportGenerator into …
Copilot 735e81b
Fix misleading comment in GetDiagnosticIfInvalidExportMethodForGenera…
Copilot ed5b226
Combine GetDiagnosticIfInvalid* into single method; remove unused Com…
Copilot efaf582
Split JSImportExportDiagnosticsAnalyzer into abstract base + two deri…
Copilot 52050b9
Move shared SupportedDiagnostics to base class; fix comments; guard u…
Copilot 8c6bd84
Use IsInPartialContext extension; deduplicate ProcessJSImportAttribute
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix misleading comment in GetDiagnosticIfInvalidExportMethodForGenera…
…tion Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
- Loading branch information
commit 735e81b9615895cb4dbcdf054a01f4822ea75f00
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.