Add gap detection to all delta collectors (#633)#638
Merged
Conversation
The maxGapSeconds + collectionTime gap detection was only on the perfmon collector. All other cumulative-counter collectors (file I/O, wait stats, query stats, procedure stats, memory grants) produced inflated deltas after app restart because the cached baseline could be hours old. Now all CalculateDelta calls pass collectionTime and maxGapSeconds=300 (5 minutes). If the gap since the last cached value exceeds 5 minutes, the delta is treated as a new baseline (returns 0) instead of computing against the stale value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
maxGapSecondsfix from PR #546 was only applied to the perfmon collector. All other cumulative-counter collectors produced inflated spike deltas after app restart.Now all 5 remaining collectors pass
collectionTimeandmaxGapSeconds: 300toCalculateDelta:Fixes the delta spike portion of #633.
🤖 Generated with Claude Code