Skip running jobs collector when login lacks msdb access#661
Merged
Conversation
- Add HAS_DBACCESS('msdb') check to the connectivity probe in ServerManager
- Store HasMsdbAccess on ServerConnectionStatus (defaults to true)
- Gate the running_jobs collector on HasMsdbAccess in IsCollectorSupported()
- Show a warning message on the Running Jobs tab when msdb access is denied
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #656
Summary
HAS_DBACCESS('msdb')check to the connectivity probe so we detect msdb permissions at connect timerunning_jobscollector viaIsCollectorSupported()— collector is silently skipped instead of failingChanges
ServerConnectionStatus.HasMsdbAccess— new property, defaults totrueServerManager.cs— connectivity probe query addsHAS_DBACCESS(N'msdb')columnRemoteCollectorService.cs—IsCollectorSupported()gatesrunning_jobsonhasMsdbAccessServerTab.xaml/.cs— warning TextBlock, collapsed by default, shown when!hasMsdbAccessMainWindow.xaml.cs— passesstatus.HasMsdbAccesstoServerTabconstructorTest plan
🤖 Generated with Claude Code