Bug: [eslint-plugin-react] Compatibility issue with ESLint 10.x.x

[akshathaPrasad]

It appears that eslint-plugin-react is not compatible with ESLint version 10.x.x.
When attempting to use eslint 10.x.x with eslint-plugin-react, I encounter dependency resolution issues, specifically that the plugin does not support ESLint 10.

React version: 19.2.4

Steps To Reproduce

1. Install eslint 10.x.x along with eslint-plugin-react@7.37.5.
2. Install dependencies
3. Encounter peer dependency conflict or related errors.

The current behavior

• Peer dependency conflicts or errors occur during installation or usage of ESLint 10 with this plugin.

The expected behavior

• eslint-plugin-react should support ESLint 10.x.x without errors.

[hansmbakker]

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: eslint-plugin-react-hooks@7.0.1
npm error Found: eslint@10.0.0
npm error node_modules/eslint
npm error   dev eslint@"^10.0.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.9.1
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.8.0" from eslint@10.0.0
npm error     @eslint-community/eslint-utils@"^4.9.1" from @typescript-eslint/utils@8.54.0
npm error     node_modules/typescript-eslint/node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"8.54.0" from typescript-eslint@8.54.0
npm error       node_modules/typescript-eslint
npm error         dev typescript-eslint@"^8.54.0" from the root project
npm error       2 more (@typescript-eslint/eslint-plugin, @typescript-eslint/type-utils)
npm error   2 more (@eslint/js, eslint-plugin-react-refresh)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0 || ^9.0.0" from eslint-plugin-react-hooks@7.0.1
npm error node_modules/eslint-plugin-react-hooks
npm error   dev eslint-plugin-react-hooks@"^7.0.1" from the root project
npm error
npm error Conflicting peer dependency: eslint@9.39.2
npm error node_modules/eslint
npm error   peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0 || ^9.0.0" from eslint-plugin-react-hooks@7.0.1
npm error   node_modules/eslint-plugin-react-hooks
npm error     dev eslint-plugin-react-hooks@"^7.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

[tomek-f]

Deps:

{
    "@eslint/js": "^10.0.1",
    "eslint": "^10.0.0",
    "eslint-plugin-react": "7.37.5",
    "eslint-plugin-react-hooks": "^7.0.1",
    "typescript-eslint": "^8.55.0"
}

ESLint config

export default defineConfig(
  globalIgnores(['**/build/*', '**/dist/*', '**/tmp/*', '!.storybook']),
  js.configs.recommended,
  tseslint.configs.strict,
  tseslint.configs.stylistic,
  pluginReact.configs.flat.recommended,
  reactHooks.configs.flat['recommended-latest'],
  // …

Output:

  eslint:eslint Using config loader ConfigLoader +0ms
  eslint:eslint Using file patterns: . +0ms
  eslint:eslint 2585 file(s) found in 1548 ms +2s
  eslint:eslint 151 file(s) to process counted in 9 ms +10ms
  eslint:eslint Linting using 4 worker thread(s). +0ms

Oops! Something went wrong! :(

ESLint: 10.0.0

TypeError: Error while loading rule 'react/no-render-return-value': contextOrFilename.getFilename is not a function
Occurred while linting /Users/tomaszfijol/Workspace/mf/__tests__/utils.ts
    at resolveBasedir (/Users/tomaszfijol/Workspace/mf/node_modules/eslint-plugin-react/lib/util/version.js:31:100)
    at detectReactVersion (/Users/tomaszfijol/Workspace/mf/node_modules/eslint-plugin-react/lib/util/version.js:85:19)
    at getReactVersionFromContext (/Users/tomaszfijol/Workspace/mf/node_modules/eslint-plugin-react/lib/util/version.js:116:25)
    at testReactVersion (/Users/tomaszfijol/Workspace/mf/node_modules/eslint-plugin-react/lib/util/version.js:181:28)
    at Object.create (/Users/tomaszfijol/Workspace/mf/node_modules/eslint-plugin-react/lib/rules/no-render-return-value.js:41:9)
    at createRuleListeners (/Users/tomaszfijol/Workspace/mf/node_modules/eslint/lib/linter/linter.js:497:15)
    at /Users/tomaszfijol/Workspace/mf/node_modules/eslint/lib/linter/linter.js:623:7
    at Array.forEach (<anonymous>)
    at runRules (/Users/tomaszfijol/Workspace/mf/node_modules/eslint/lib/linter/linter.js:557:31)
    at #flatVerifyWithoutProcessors (/Users/tomaszfijol/Workspace/mf/node_modules/eslint/lib/linter/linter.js:1248:4)

[Damienb123]

Hi all! I've been reviewing this issue while looking for my first open source contribution, and wanted to share what I found.

Beyond the peer dependency conflicts, this appears to be a runtime incompatibility with ESLint 10. Using ESLint 10.0.0 with flat config and eslint-plugin-react@7.35.5, the rule react/no-render-return-value crashes with:

TypeError: contextOrFilename.getFilename is not a function

The stack trace points to lib/util/version.js during React version detection, which seems affected by ESLint 10 RuleContext API changes. This likely impacts multiple rules relying on detectReactVersion().

I'm a new contributor, but I'd be happy to try working on an ESLint-10-compatible fix with the related helpers if additional support would be useful!

[lpicchi]

The eslint plugins are using

context.getSourceCode() and context.getFilename() deeprecated in ESLint 9 and removed in ESLint 10

Whoever using this plugins will not be able to upgrade to ESLint 10 for the time being

[JstnMcBrd]

Has this issue been resolved by #35720?

[hansmbakker]

Has this issue been resolved by #35720?

Not sure, because it seems it has not been released yet.

[lpicchi]

@akshathaPrasad I realised this issue was created in the wrong repo. This is elint-plugin-react repo