Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

xster
Copy link
Member

@xster xster commented Mar 14, 2020


/**
* The FlutterEngine class coordinates a single instance of execution for a
* The `FlutterEngine` class coordinates a single instance of execution for a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't do this in any of the other headers (that is, self-link to the class being documented). If we really want to do this, we should probably be consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and two places below this in this file)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@xster xster merged commit 09bc1fc into flutter:master Apr 3, 2020
@xster xster deleted the objcdoc branch April 3, 2020 20:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2020
cbracken pushed a commit to flutter/flutter that referenced this pull request Apr 3, 2020
* e55b447 Use const refs in for loops where reasonable (flutter/engine#17484)

* e2b8655 Roll src/third_party/skia 8efbbbc0d1d4..e70e0c055f56 (1 commits) (flutter/engine#17496)

* a9c6222 Roll fuchsia/sdk/core/mac-amd64 from 6V5BR... to tKvUB... (flutter/engine#17497)

* fa09075 Roll fuchsia/sdk/core/linux-amd64 from -jFTb... to TWx2R... (flutter/engine#17498)

* 983d1e1 Fix include paths of fml/time headers in the shell and rasterizer (flutter/engine#17502)

* 09bc1fc Small updates to objcdocs (flutter/engine#17151)
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and complete all relevant Java/ObjC docs for add-to-app

4 participants