This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixed nullability in plugin header and overridden type mismatch error. #17532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
Apr 6, 2020
| #include "flutter/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h" | ||
| #include "flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate_internal.h" | ||
|
|
||
| #pragma GCC diagnostic error "-Woverriding-method-mismatch" |
There was a problem hiding this comment.
It seems like this flag should apply to all files. What about setting this in flutter/shell/platform/darwin/ios/BUILD.gn?
There was a problem hiding this comment.
That would require changing a lot of files not apropos to the issue I'm fixing. I can add an issue to make that happen. flutter/flutter#54136
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2020
tvolkert
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2020
* 0945635 Roll src/third_party/skia cc8a76f3c763..04513752fd6e (22 commits) (flutter/engine#17529) * faf44fe Improve C++ plugin lifetime handling (flutter/engine#17489) * 4b69cf2 [tools][fuchsia] Do not tar debug symbol CIPD uploads (flutter/engine#17506) * 19a7fbf Fixed nullability in plugin header and overridden type mismatch error. (flutter/engine#17532) * ab434c5 Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads (#17506)" (flutter/engine#17537)
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant issue: flutter/flutter#22573