This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] fix clipboard.getData #17544
Merged
[web] fix clipboard.getData #17544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y with the content of the clipboard
mdebbar
reviewed
Apr 7, 2020
We can't write a unit test. We can maybe write an integration test (the reason I say may be is we need to approve the permission pop-up somehow). I am looking to the possibility. At worst scenario though, we can write an integration test that uses one of the branches (exec-command branch) |
ferhatb
approved these changes
Apr 7, 2020
|
Merging the PR since it is not related to Windows Host. We will merge the tests later. Looks like @ferhatb has a test. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard * also remove the fake answer for copy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard
Fixes flutter/flutter#53983
Note: This feature is not tested so it breaks with other changes. I'll send an integration tests after merging this PR in to protect the feature towards future changes.
(I'm not sending it now, cause I still need to find a way of giving driver clipboard permission :) or another workaround to test the clipboard.dart code)