This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert getSystemGestureExclusionRects and setSystemGestureExclusionRects #17613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…cts (flutter#17613) * Revert getSystemGestureExclusionRects and setSystemGestureExclusionRects * Remove references to removed PlatformChannelTest.java file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it makes more sense for this functionality to be exposed as a plugin, I'm reverting its implementation in the engine. Discussion for this is in flutter/flutter#39858, but essentially, platform-specific APIs make more sense in the form of a plugin, since this behavior will not apply to non-Android platforms.
Reverts #11804, #11451, #11441