Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

skia-flutter-autoroll
Copy link
Contributor

https://dart.googlesource.com/sdk.git/+log/89b0f6726123..23a8788f6a9c

git log 89b0f67..23a8788 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 scheglov@google.com Issue 41378. Update on-catch and throw for the spec changes.

Created with:
gclient setdep -r src/third_party/dart@23a8788f6a9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com

https://dart.googlesource.com/sdk.git/+log/89b0f6726123..23a8788f6a9c

git log 89b0f67..23a8788 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 scheglov@google.com Issue 41378. Update on-catch and throw for the spec changes.

Created with:
  gclient setdep -r src/third_party/dart@23a8788f6a9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 12, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-2-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 12, 2020
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 12, 2020
@fluttergithubbot fluttergithubbot merged commit 720645e into flutter:master Apr 12, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2020
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants