This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Convert semantics_node from SkMatrix44 to SkM44 #17763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 16, 2020
| node.screen_rect.setLTRB(dst[0], dst[1], dst[8], dst[9]); | ||
| node.screen_rect.setLTRB(dst[0].x, dst[0].y, dst[1].x, dst[1].y); | ||
| node.screen_rect.sort(); | ||
| std::vector<SkVector4> points = { |
There was a problem hiding this comment.
huh, this was just unused?
There was a problem hiding this comment.
Yup, it was sort of redundant with the previous chunk of code, and then the result was never used. Also, the previous code transformed all four corners, but then only used the results from two of them.
|
Not sure if it was intentional, but I don't think we generally want to land CLs with failed checks, on red tree unless those CLs are directed at turning the tree green. |
|
Sorry about this. This is part of my ongoing frustration with the checks system here. I re-tried the two red checks, and they both passed, but the UI here never picks up that information. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2020
cbracken
reviewed
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.