This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Don't allow empty initial route #17936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
reviewed
Apr 24, 2020
nturgut
reviewed
Apr 24, 2020
| return '/'; | ||
| } | ||
| // At this point, we know [path] starts with "#" and isn't empty. | ||
| return path.substring(1); |
There was a problem hiding this comment.
unrelated to this PR: I wonder if we can tests these things in integration tests now :)
There was a problem hiding this comment.
Yep. I think this can be done as part of the single integration test that goes through the gallery app and clicks around.
nturgut
approved these changes
Apr 24, 2020
26ac69a to
eb35e42
Compare
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initial route is an empty string, it breaks routing in Flutter because it doesn't match the default "/". This PR fixes the issue by never returning an empty string as a path. Instead it returns "/" when the path is an empty string.
Fixes flutter/flutter#55426