This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change the repo fetch script used in integration tests #17943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches.
tvolkert
reviewed
Apr 24, 2020
|
Thanks for the review. The tests passed, merging the PR. |
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2020
This was referenced Apr 26, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2020
This was referenced Apr 26, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 27, 2020
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Apr 27, 2020
* change the repo fetch script to recognize candidate versions such as flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches. * addressing reviewer comments: changing the release regular expression
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
May 1, 2020
* change the repo fetch script to recognize candidate versions such as flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches. * addressing reviewer comments: changing the release regular expression
pcsosinski
pushed a commit
that referenced
this pull request
May 2, 2020
* use $CIRRUS_BASE_BRANCH for the branch name (#18014) use $CIRRUS_BASE_BRANCH for getting the branch name when cloning the flutter repo. * Change the repo fetch script used in integration tests (#17943) * change the repo fetch script to recognize candidate versions such as flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches. * addressing reviewer comments: changing the release regular expression Co-authored-by: Nurhan Turgut <nurhan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the repo fetch script to recognize candidate versions such as flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches.
This will fix test breakages such as: #17931