Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reenable flutter scenic test to identify crashes and follow up on fixes. #17979

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Reenable flutter scenic test to identify crashes and follow up on fixes. #17979

merged 1 commit into from
Apr 27, 2020

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc added the Work in progress (WIP) Not ready (yet) for review! label Apr 27, 2020
@auto-assign auto-assign bot requested a review from flar April 27, 2020 17:56
@godofredoc godofredoc removed the Work in progress (WIP) Not ready (yet) for review! label Apr 27, 2020
iskakaushik
iskakaushik approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar removed their request for review April 27, 2020 20:17
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 27, 2020
@fluttergithubbot fluttergithubbot merged commit 027eff8 into flutter:master Apr 27, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
@godofredoc godofredoc deleted the reenable_scenic_test branch April 28, 2020 01:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 28, 2020
@engine-flutter-autoroll
027eff8 Reenable flutter scenic test to identify crashes and follow u…
738790f 
…p on fixes. (flutter/engine#17979)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 28, 2020
@engine-flutter-autoroll
027eff8 Reenable flutter scenic test to identify crashes and follow u…
b208e90 
…p on fixes. (flutter/engine#17979)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 28, 2020
@engine-flutter-autoroll
027eff8 Reenable flutter scenic test to identify crashes and follow u…
e95603f 
…p on fixes. (flutter/engine#17979)
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 28, 2020
@engine-flutter-autoroll
027eff8 Reenable flutter scenic test to identify crashes and follow u…
052f4e2 
…p on fixes. (flutter/engine#17979)
This was referenced Apr 28, 2020
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2020
Closed
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 28, 2020
@engine-flutter-autoroll
027eff8 Reenable flutter scenic test to identify crashes and follow u…
3bad206 
…p on fixes. (flutter/engine#17979)
@christopherfujino christopherfujino mentioned this pull request Apr 28, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@farchond farchond Awaiting requested review from farchond

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @iskakaushik @googlebot @fluttergithubbot