Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add FlBasicMessageChannel #18189

Merged
merged 1 commit into from
May 14, 2020
Merged

Add FlBasicMessageChannel #18189

merged 1 commit into from
May 14, 2020

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented May 7, 2020 •
edited
Loading

No description provided.

@auto-assign auto-assign bot requested a review from cbracken May 7, 2020 04:56
@robert-ancell robert-ancell mentioned this pull request May 7, 2020
Closed
@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch from 5187d63 to 198ce1c Compare May 7, 2020 22:25
@robert-ancell robert-ancell mentioned this pull request May 7, 2020
Merged
@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch 12 times, most recently from 1efb24d to 903e101 Compare May 11, 2020 04:58
stuartmorgan-g
stuartmorgan-g reviewed May 11, 2020
View reviewed changes
@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch 3 times, most recently from ca4751f to 48ede6c Compare May 11, 2020 22:23
stuartmorgan-g
stuartmorgan-g reviewed May 11, 2020
View reviewed changes
@stuartmorgan-g
Copy link
Contributor

Can you add tests for this, including one that would have caught the response bug?

@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch 2 times, most recently from 41a03c9 to 636f21f Compare May 11, 2020 23:51
@robert-ancell robert-ancell mentioned this pull request May 12, 2020
Merged
@robert-ancell
Copy link
Contributor Author

Can you add tests for this, including one that would have caught the response bug?

I really need to make a mock FlutterEngine to do this, then I can add the missing tests for FlBinaryMessenger. I'm currently looking at the flutter/text-input channel as that's a higher risk but will cycle back to the tests after that.

@robert-ancell robert-ancell mentioned this pull request May 12, 2020
Closed
stuartmorgan-g
stuartmorgan-g approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nit about a TODO. Revisiting tests once there's a fake engine SGTM.

@robert-ancell
Copy link
Contributor Author

I've got flutter/flutter#56261 to track the missing tests.

@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch from 636f21f to 0990152 Compare May 13, 2020 22:43
@robert-ancell robert-ancell force-pushed the linux-shell-fl-basic-message-channel branch from 0990152 to b7c58d3 Compare May 13, 2020 22:46
stuartmorgan-g
stuartmorgan-g approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell merged commit 9600354 into flutter:master May 14, 2020
@robert-ancell robert-ancell deleted the linux-shell-fl-basic-message-channel branch May 14, 2020 00:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2020
@engine-flutter-autoroll
9600354 Add FlBasicMessageChannel (flutter/engine#18189)
5e2a54b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2020
@engine-flutter-autoroll
9600354 Add FlBasicMessageChannel (flutter/engine#18189)
c4b2b8d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2020
@engine-flutter-autoroll
9600354 Add FlBasicMessageChannel (flutter/engine#18189)
4c46e8e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2020
Merged
iskakaushik pushed a commit to flutter/flutter that referenced this pull request May 14, 2020
@engine-flutter-autoroll
Roll engine ae2222f..47513a7 (21 commits) (#57252)
573625b 
* 9e3e3ba [web] Represent CSS identity transforms as 'none' instead of null (flutter/engine#18288)

* 80fa77e Roll src/third_party/skia 3ebadcc98eab..056d543c91e0 (8 commits) (flutter/engine#18344)

* 480d8e4 Fix scenario platform view tests on Android (flutter/engine#18332)

* 0385664 Roll src/third_party/dart d6fed1f62444..29c00e28f350 (16 commits) (flutter/engine#18347)

* 8371b44 Roll src/third_party/skia 056d543c91e0..71903997254f (7 commits) (flutter/engine#18350)

* f321613 Add guards on FlValue methods to check for NULL values (flutter/engine#18226)

* dc93db5 Move FlutterLoader disk I/O to a background thread to comply with Android strict mode (flutter/engine#18241)

* bf1287c null-annotate lerp.dart, annotations.dart, channel_buffers.dart, hash_codes.dart (flutter/engine#18348)

* 9600354 Add FlBasicMessageChannel (flutter/engine#18189)

* df2dfac Roll src/third_party/skia 71903997254f..6c3db04c8b03 (9 commits) (flutter/engine#18361)

* 5ad4f9e Add FlJsonMessageCodec (flutter/engine#18221)

* 84ea892 Roll src/third_party/skia 6c3db04c8b03..7156db260239 (4 commits) (flutter/engine#18370)

* f848069 Roll src/third_party/dart 29c00e28f350..f99631b12c4a (29 commits) (flutter/engine#18373)

* c791ce9 Roll src/fuchsia/sdk/mac from gOhJW... to Vepm4... (flutter/engine#18377)

* 5b62a63 Roll src/third_party/dart f99631b12c4a..e0257265d34e (2 commits) (flutter/engine#18378)

* 0b41009 Roll src/third_party/skia 7156db260239..5b2ede3d0d44 (8 commits) (flutter/engine#18380)

* 08b61ce Delete unused decode UTF-8, JSON functions (flutter/engine#18360)

* 73d835c Roll src/third_party/dart e0257265d34e..2676764792b2 (4 commits) (flutter/engine#18383)

* 9e166fb Roll src/third_party/skia 5b2ede3d0d44..39ec60aa8348 (5 commits) (flutter/engine#18384)

* 2cdbc7f Remove pipeline in favor of layer tree holder (flutter/engine#18285)

* 47513a7 Roll src/third_party/skia 39ec60aa8348..79c5674a4ca1 (3 commits) (flutter/engine#18389)
wandyers pushed a commit to wandyers/engine that referenced this pull request May 23, 2020
@robert-ancell @wandyers
Add FlBasicMessageChannel (flutter#18189)
1baab6a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robert-ancell @stuartmorgan-g @googlebot