implement MaskFilter.blur as shadow on Safari #18216
Conversation
| void drawLine(ui.Offset p1, ui.Offset p2, SurfacePaintData paint) { | ||
| _applyPaint(paint); | ||
| _canvasPool.strokeLine(p1, p2); | ||
| _withPaint(paint, () { |
There was a problem hiding this comment.
will likely allocate a new class instance for each call due to closure.
There was a problem hiding this comment.
Done. Changed it to _setUpPaint/_tearDownPaint methods.
8317167 to
f6147f1
Compare
f6147f1 to
b76793c
Compare
c2306be to
13bc108
Compare
| return scaled(arg); | ||
| } | ||
| if (arg is Vector3) { | ||
| return transformed3(arg); |
There was a problem hiding this comment.
aim was to to reduce allocation/copy, why the change?
There was a problem hiding this comment.
The copyless version is transform3. I removed transformed3, which was making copies. I wasn't sure if operator * is still used, so I'm not changing it yet.
| /// commands prior to painting do not need to be cleared. | ||
| /// | ||
| /// Must be called after calling [setUpPaint]. | ||
| void tearDownPaint() { |
There was a problem hiding this comment.
Does this get removed dart2js release? Maybe place all tearDownPaint() calls inside asserts?
There was a problem hiding this comment.
It should not be removed. Otherwise the context won't be restored.
There was a problem hiding this comment.
Got it. likely very small will be inlined
There was a problem hiding this comment.
Would be nice if we had access to dart2js inlining annotations.
| if (requiresClipping) { | ||
| restore(); | ||
| } | ||
| _closeCurrentCanvas(); |
There was a problem hiding this comment.
instead you could remove _closeCurrentCanvas on line 446 in if clause.
There was a problem hiding this comment.
Hmm, I'm actually not sure what this change is about. Must have been a bad merge 🤔
Let me check.
There was a problem hiding this comment.
Ah, right, this was a drive-by change to avoid double-closing. Yes, I will remove the other one. Good catch.
|
Mac iOS Engine failure is unrelated. Merging. |
* implement MaskFilter.blur as shadow on Safari
Fixes flutter/flutter#55930
Requires flutter/goldens#96