This repository was archived by the owner on Feb 25, 2025. It is now read-only.
sync ui geometry.dart into web_ui geometry.dart; add null safety annotations #18356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
May 14, 2020
| /// vertical component. | ||
| const OffsetBase(double dx, double dy) | ||
| : _dx = dx ?? 0.0, | ||
| _dy = dy ?? 0.0, |
There was a problem hiding this comment.
Wow -- this was for the STRAIGHT TO RELEASE MODE crowd I guess :)
cbracken
reviewed
May 14, 2020
lib/ui/geometry.dart
Outdated
|
|
||
| @override | ||
| String toString() => 'OffsetBase(${_dx?.toStringAsFixed(1)}, ${_dy?.toStringAsFixed(1)})'; | ||
| String/*!*/ toString() => 'OffsetBase(${_dx?.toStringAsFixed(1)}, ${_dy?.toStringAsFixed(1)})'; |
There was a problem hiding this comment.
Shouldn't we kill the ?s here?
cbracken
reviewed
May 14, 2020
| /// Creates an offset. The first argument sets [dx], the horizontal component, | ||
| /// and the second sets [dy], the vertical component. | ||
| const Offset(double dx, double dy) : super(dx, dy); | ||
| const Offset(double/*!*/ dx, double/*!*/ dy) : super(dx, dy); |
There was a problem hiding this comment.
Optionally, add non-null asserts for dx/dy here for (hopefully very limited-time) future proofing.
There was a problem hiding this comment.
The super already does that (as of this PR).
cbracken
reviewed
May 14, 2020
lib/ui/geometry.dart
Outdated
|
|
||
| @override | ||
| String toString() => 'Offset(${dx?.toStringAsFixed(1)}, ${dy?.toStringAsFixed(1)})'; | ||
| String/*!*/ toString() => 'Offset(${dx?.toStringAsFixed(1)}, ${dy?.toStringAsFixed(1)})'; |
There was a problem hiding this comment.
The tool actually did it automatically! But removed anyway.
cbracken
reviewed
May 14, 2020
lib/ui/geometry.dart
Outdated
|
|
||
| @override | ||
| String toString() => 'Size(${width?.toStringAsFixed(1)}, ${height?.toStringAsFixed(1)})'; | ||
| String/*!*/ toString() => 'Size(${width?.toStringAsFixed(1)}, ${height?.toStringAsFixed(1)})'; |
cbracken
reviewed
May 14, 2020
| class Size extends OffsetBase { | ||
| /// Creates a [Size] with the given [width] and [height]. | ||
| const Size(double width, double height) : super(width, height); | ||
| const Size(double/*!*/ width, double/*!*/ height) : super(width, height); |
There was a problem hiding this comment.
Again optionally add the asserts.
There was a problem hiding this comment.
Same here: see the implementation of OffsetBase.
|
The pending bots are infra flakiness. Merging. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
…tations (flutter#18356) sync ui geometry.dart into web_ui geometry.dart; add null safety
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.