Add screenshots for Android view #18367
Conversation
1a35526 to
8f10c51
Compare
8f10c51 to
a28af3b
Compare
a28af3b to
3d30523
Compare
testing/scenario_app/lib/main.dart
Outdated
| callback(Uint8List.fromList(utf8.encode(timelineData)).buffer.asByteData()); | ||
| break; | ||
| default: | ||
| print('Unimplemented channel: $name.'); |
There was a problem hiding this comment.
Err, actually, why not just pass this down to onPlatformMessage of the scenario that's running?
There was a problem hiding this comment.
getCurrentScenario()?.onPlatformMessage(....)
There was a problem hiding this comment.
This is an unimplemented channel. I think throwing should be fine. If this case occurs, then some mistake was made in the platform test.
There was a problem hiding this comment.
But how will a scenario that wants to set up a custom channel do so now?
There was a problem hiding this comment.
If we want to do this, we should remove the onPlatformMessage from the scenario base class.
There was a problem hiding this comment.
oh gotcha. That makes sense. It should continue to call currentScenario?.onPlatformMessage(..).
Adds the screenshots for the Android view. It's expected that the screenshots don't render the Android view since the code hasn't been implemented yet.
I refactored the scenario test app a bit, so that it's possible to pass additional configuration data over the channel.