Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

renyou
Copy link
Contributor

@renyou renyou commented Jun 3, 2020

Description

*Replace this paragraph with a description of what this PR is doing. If you're
modifying existing behavior, describe the existing behavior, how this PR is
changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue
database
. Indicate, which of these issues are resolved or fixed by this PR.
There should be at least one issue listed here.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A
change in behaviour with no test covering it will likely get reverted
accidentally sooner or later. PRs must include tests for all
changed/updated/fixed behaviors. See testing the engine for instructions on
writing and running engine tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@auto-assign auto-assign bot requested a review from liyuqian June 3, 2020 22:05
@renyou renyou requested review from pcsosinski and tvolkert June 3, 2020 22:05
@renyou renyou added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 4, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 4, 2020
@renyou
Copy link
Contributor Author

renyou commented Jun 4, 2020

@renyou renyou merged commit d17c84e into flutter:flutter-1.19-candidate.4 Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants