This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move Surface and friends to flow/ #18938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circular dependencies are cropping up between shell/common/ and flow/, so just move all of this stuff down into flow itself. These classes are all rasterization-related anyways. shell/common/ has Dart dependenices, and a future CL will create non-product and product permutations of any target with Dart dependencies. Moving all of the rasterization-related code to its own library with no Dart dependencies means no permutations need to be made of it. Tested: Just compile, this is a mechanical change
chinmaygarde
approved these changes
Jun 9, 2020
|
This broke iOS builds. For some reason, the mac presubmits didn't run on this at all. @godofredoc |
|
(Fixed forward in #18950) |
|
This is because mac builds have a very long queue time and the status are updated only after they are scheduled to run. flutter/flutter#56421 |
|
This is the one for the long queue time: flutter/flutter#59036 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
This was referenced Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2020
This was referenced Jun 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circular dependencies are cropping up between shell/common/ and flow/,
so just move all of this stuff down into flow itself. These classes are
all rasterization-related anyways.
shell/common/ has Dart dependenices, and a future CL will create
non-product and product permutations of any target with Dart
dependencies. Moving all of the rasterization-related code to its own
library with no Dart dependencies means no permutations need to be made
of it.
Tested: Just compile, this is a mechanical change
BUG: 52961