This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add PlatformView support for Fuchsia #19132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on the ShellTest timeout. |
iskakaushik
approved these changes
Jun 24, 2020
| }); | ||
| } | ||
|
|
||
| flutter::ExternalViewEmbedder* Engine::GetViewEmbedder() { |
There was a problem hiding this comment.
can we make this a shared_ptr?
There was a problem hiding this comment.
My next CL is going to move the ExternalViewEmbedder into the engine and make it a shared_ptr there, so it makes sense to just do it now
|
Can you please rebase to head? I added a recipe change to the Web Engine but needs the most recent code to run. Sorry for the inconvenience. |
|
@nturgut Sure thing. |
This change allows embedding views provided by fuchsia components into a flutter app running on Fuchsia. This conforms to Flutters idiomatic approach to composite PlatformView alongside other rendered layers. This uses the `view embedder` infrastructure to allow `PlatformViewLayer` to hold fuchsia views. This is meant to eventually supplant the legacy `SceneHost` and `ChildViewLayer` mechanism to embed fuchsia `ChildView`. To see how this will get used check out: https://fuchsia-review.googlesource.com/c/experiences/+/398536/6/examples/hello_experiences/lib/fuchsia_view.dart Includes unittests for platform_view.cc. Note: This change has no impact on the legacy code to embed fuchsia views.
f41d0f0 to
03c6beb
Compare
arbreng
approved these changes
Jun 25, 2020
| }); | ||
| } | ||
|
|
||
| flutter::ExternalViewEmbedder* Engine::GetViewEmbedder() { |
There was a problem hiding this comment.
My next CL is going to move the ExternalViewEmbedder into the engine and make it a shared_ptr there, so it makes sense to just do it now
Same for OnDestroyViewMethodCall to OnDestroyView
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows embedding views provided by fuchsia components into
a flutter app running on Fuchsia. This conforms to Flutters idiomatic
approach to composite PlatformView alongside other rendered layers.
This uses the
view embedderinfrastructure to allowPlatformViewLayerto hold fuchsia views. This is meant to eventually supplant the legacy
SceneHostandChildViewLayermechanism to embed fuchsiaChildView.To see how this will get used check out:
https://fuchsia-review.googlesource.com/c/experiences/+/398536/6/examples/hello_experiences/lib/fuchsia_view.dart
Note: This change has no impact on the legacy code to embed fuchsia
views.
Tests
Includes unittests for platform_view.cc.