This repository was archived by the owner on Feb 25, 2025. It is now read-only.
EndFrame should be always called by rasterizer #19257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyanglaz I verified this fixes the perf issue you were seeing. |
cyanglaz
approved these changes
Jun 24, 2020
flow/embedded_views.h
Outdated
| // This method provides the embedder a way to do additional tasks after | ||
| // |SubmitFrame|. After invoking this method, the current task on the | ||
| // TaskRunner should end immediately. | ||
| // |SubmitFrame|. For example, merge tasks if `should_resubmit_frame` is true. |
There was a problem hiding this comment.
nits: merge task runners?
| TRACE_EVENT0("flutter", "IOSSurface::EndFrame"); | ||
| FML_CHECK(platform_views_controller_ != nullptr); | ||
| return platform_views_controller_->EndFrame(raster_thread_merger); | ||
| return platform_views_controller_->EndFrame(raster_status, raster_thread_merger); |
There was a problem hiding this comment.
platform_views_controller_->EndFrame(should_resubmit_frame, raster_thread_merger); ?
| // causes|RasterStatus::kResubmit|. Check to make sure. | ||
| FML_DCHECK(external_view_embedder != nullptr); | ||
| external_view_embedder->EndFrame(raster_thread_merger_); | ||
| if (surface_ != nullptr && surface_->GetExternalViewEmbedder() != nullptr) { |
There was a problem hiding this comment.
maybe also modify the https://github.com/flutter/engine/blob/master/shell/common/shell_unittests.cc#L472 test to make sure the should_resubmit_frame flag is passed correctly?
There was a problem hiding this comment.
ah, didn't know there was that test
13 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2020
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Jun 24, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EndFrameshould be called by the rasterizer as it is used to restore up state or recycle the overlay surfaces.Related Issues
Fixes flutter/flutter#60124
Tests
I added the following tests: updated unit tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.