Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "fuchsia: Fix profile build" #19493

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Revert "fuchsia: Fix profile build" #19493

merged 1 commit into from
Jul 3, 2020

Conversation

renyou
Copy link
Contributor

@renyou renyou commented Jul 3, 2020

Reverts #19399

@auto-assign auto-assign bot requested a review from chinmaygarde July 3, 2020 12:43
@renyou renyou requested review from arbreng and mehmetf July 3, 2020 12:43
@mehmetf
Copy link
Contributor

mehmetf commented Jul 3, 2020

Let's wait to verify that the revert fixes the g3 test.

@renyou
Copy link
Contributor Author

renyou commented Jul 3, 2020

Let's wait to verify that the revert fixes the g3 test.

Verified.

@renyou renyou merged commit 6184f62 into master Jul 3, 2020
renyou added a commit to renyou/engine that referenced this pull request Jul 3, 2020
@renyou
Revert "fuchsia: Fix profile build (flutter#19399)" (flutter#19493)
c6eba62 
This reverts commit a974b78.
renyou added a commit that referenced this pull request Jul 3, 2020
@renyou
Flutter 1.20 candidate.3 (#19499)
a751393 
* Revert "fuchsia:  Fix profile build (#19399)" (#19493)

This reverts commit a974b78.

* Revert "Add tests & --unopt to build_fuchsia_artifacts (#18625)" (#19494)

This reverts commit fae8141.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2020
@engine-flutter-autoroll
6184f62 Revert "fuchsia: Fix profile build (flutter#19399)" (flutter/…
2909e42 
…engine#19493)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2020
@engine-flutter-autoroll
6184f62 Revert "fuchsia: Fix profile build (flutter#19399)" (flutter/…
400b280 
…engine#19493)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2020
@engine-flutter-autoroll
6184f62 Revert "fuchsia: Fix profile build (flutter#19399)" (flutter/…
bef9392 
…engine#19493)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
@engine-flutter-autoroll
6184f62 Revert "fuchsia: Fix profile build (flutter#19399)" (flutter/…
fa083e2 
…engine#19493)
mehmetf pushed a commit that referenced this pull request Jul 7, 2020
@renyou @mehmetf
Revert "fuchsia: Fix profile build (#19399)" (#19493)
671b4fb 
This reverts commit a974b78.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
@engine-flutter-autoroll
6184f62 Revert "fuchsia: Fix profile build (flutter#19399)" (flutter/…
51a3149 
…engine#19493)
@chinmaygarde chinmaygarde deleted the revert-19399-fix-fuchsia-profile branch November 3, 2021 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@mehmetf mehmetf Awaiting requested review from mehmetf

1 more reviewer

@arbreng arbreng arbreng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renyou @mehmetf @arbreng @googlebot