Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web][1/3] Start first batch of auto-generated (already passing) tests for line break #19586

Merged
merged 2 commits into from
Jul 8, 2020
Merged

[web][1/3] Start first batch of auto-generated (already passing) tests for line break #19586

merged 2 commits into from
Jul 8, 2020

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jul 7, 2020 •
edited
Loading

Description

This is one of 3 PRs to complete the line break algorithm:

  1. [THIS] Add the first batch of auto-generated (already passing) tests.
  2. [COMPLETE] Implement the algorithm and add more test cases ([web][2/3] Implement rules of the line break algorithm #19610).
  3. [COMPLETE] Fix surrogates and add the last batch of test cases ([web][3/3] Handle surrogate during line break detection #19745).

Related Issues

flutter/flutter#45932

Tests

I added the following tests:

  • test/text/line_breaker_test.dart

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Jul 7, 2020
@mdebbar mdebbar requested review from ferhatb and yjbanov July 7, 2020 18:49
@mdebbar mdebbar self-assigned this Jul 7, 2020
@mdebbar mdebbar changed the title [web] Start first batch of auto-generated (already passing) tests for line break [WIP][web] Start first batch of auto-generated (already passing) tests for line break Jul 7, 2020
@mdebbar
Copy link
Contributor Author

mdebbar commented Jul 7, 2020 •
edited
Loading

Please hold off reviewing this PR. I made a mistake and put too many test cases (including ones that are still failing).

@mdebbar mdebbar changed the title [WIP][web] Start first batch of auto-generated (already passing) tests for line break [web] Start first batch of auto-generated (already passing) tests for line break Jul 7, 2020
@mdebbar mdebbar changed the title [web] Start first batch of auto-generated (already passing) tests for line break [web][1/3] Start first batch of auto-generated (already passing) tests for line break Jul 7, 2020
ferhatb
ferhatb approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@ferhatb ferhatb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit otherwise lgtm

lib/web_ui/test/text/line_breaker_test_data.dart Outdated
/// - https://www.unicode.org/Public/13.0.0/ucd/auxiliary/LineBreakTest.txt
final List<TestCase> data = _rawData.map(_parse).toList();

final RegExp sp = RegExp(r'\s+');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: name space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mdebbar
Copy link
Contributor Author

mdebbar commented Jul 8, 2020

Failures are unrelated to this PR. Merging.

@mdebbar mdebbar merged commit 0ec6f6c into flutter:master Jul 8, 2020
@mdebbar mdebbar mentioned this pull request Jul 8, 2020
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 8, 2020
@engine-flutter-autoroll
0ec6f6c [web][1/3] Start first batch of auto-generated (already passi…
20315a8 
…ng) tests for line break (flutter/engine#19586)
@mdebbar mdebbar mentioned this pull request Jul 14, 2020
Merged
@mdebbar mdebbar deleted the auto_tests branch April 15, 2021 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

1 more reviewer

@ferhatb ferhatb ferhatb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdebbar mdebbar

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @ferhatb @googlebot