This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll buildroot to pull in removal of //tools. #47032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e538c9 to
baea031
Compare
cbracken
approved these changes
Oct 17, 2023
chinmaygarde
added a commit
to flutter/buildroot
that referenced
this pull request
Oct 17, 2023
None of these except remove_stale_pyc_files seems to be used. But we have the pyc files in the .gitignore and I couldn't find any existing checked in pyc files. So this check has never made sense for the Flutter. Removing instead of migrating. Engine patch flutter/engine#47032
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2023
…136777) flutter/engine@2eef9b4...3f818ef 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033) 2023-10-18 chinmaygarde@google.com Roll buildroot to pull in removal of //tools. (flutter/engine#47032) 2023-10-18 jonahwilliams@google.com Disable threading test that fails on CI (flutter/engine#47034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Oct 18, 2023
Reverts #47032 This is causing the Dart -> Engine roll to fail because one of the removed scripts is used by the autoroller.
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
None of these except remove_stale_pyc_files seems to be used. But we have the pyc files in the .gitignore and I couldn't find any existing checked in pyc files. So this check has never made sense for the Flutter. Removing instead of migrating. Buildroot patch flutter/buildroot#784
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Reverts #47032 This is causing the Dart -> Engine roll to fail because one of the removed scripts is used by the autoroller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.
Buildroot patch flutter/buildroot#784