Add Android Emulator dependencies as "test_dependencies" to Android tests #47384
Conversation
|
@godofredoc I looked at the docs and this is what I would assume @gmackall needs to add in order to specify the version of the emulator. This change here allows this to pick up the required version. |
There was a problem hiding this comment.
Thanks for this PR and the linked fix! This LGTM, but can we try running it once in presubmit by changing presubmit to true here temporarily (given that this PR not only adds the configuration, but also actually changes the version to 34).
|
@gmackall Yeah no problem. Here is a successful run on prod: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/ricardoamador_google.com/aef0a5e0460f39de6935d45dd12b797fba9b2d15d29d95662d34d9e466c39584/+/build.proto. I'll run some tests on try and update the PR to run in presubmit. Do you want it to run in presubmit always or just for a test? |
There was a problem hiding this comment.
@gmackall Yeah no problem. Here is a successful run on prod: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/ricardoamador_google.com/aef0a5e0460f39de6935d45dd12b797fba9b2d15d29d95662d34d9e466c39584/+/build.proto.
I'll run some tests on try and update the PR to run in presubmit. Do you want it to run in presubmit always or just for a test?
Oh nevermind, I just wanted to see one run succeed to be sure it wouldn't end up just failing in postsubmit. If you've already tested a successful run then this LGTM!
Separately, I know this test used to run in presubmit and was changed to only postsubmit ~4 months ago, and I want to look into why that is/see if it should be changed back to running in presubmit. But thats a different issue!
|
Here you go: https://chromium-swarm.appspot.com/task?id=658bf0608be42710 in the try pool. Also note that the recipe change will need to land first then I can merge this and you should be good to go. |
…137462) flutter/engine@f1e30b4...a768211 2023-10-28 32242716+ricardoamador@users.noreply.github.com Add Android Emulator dependencies as "test_dependencies" to Android tests (flutter/engine#47384) 2023-10-27 mdebbar@google.com [web] DomManager for each FlutterView (flutter/engine#47388) 2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 77abd518ad4a to 64f13d5be3f7 (2 revisions) (flutter/engine#47406) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
Emulator dependencies were not getting picked up correctly when running the Recipes through engine_v2. The fix was to allow the context it runs through to be passed the version via the flutter_deps module. That change can be found here: https://flutter-review.googlesource.com/c/recipes/+/51869.
Do not land until above cl has been merged.
Related Issue
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#137350
Validation
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.