Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

johnmccutchan
Copy link
Contributor

This reverts commit 87c3bf1. It is no longer needed as we have resolved the flickering issue in the ImageReader backend.

@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2023
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elle gee tee em

Copy link
Contributor

auto-submit bot commented Nov 14, 2023

auto label is removed for flutter/engine/48024, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2023
@johnmccutchan johnmccutchan merged commit a00c22e into flutter:main Nov 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 14, 2023
…138425)

flutter/engine@603bdd4...eba7578

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 5fbacd5d68a5 to 63037925e344 (1 revision) (flutter/engine#48028)
2023-11-14 john@johnmccutchan.com Revert "Add an AndroidManifest.xml flag to disable ImageReader backend Platform Views (#46430)" (flutter/engine#48024)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ce88be2adf67 to 5fbacd5d68a5 (1 revision) (flutter/engine#48026)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants